View Issue Details

IDProjectCategoryView StatusLast Update
0000721Subversion for OS/2 & eCSBugpublic2020-09-10 02:28
ReporterLewisRAssigned To 
PrioritynormalSeverityminorReproducibilityalways
Status newResolutionopen 
Product Version1.14.x 
Target Version1.14.xFixed in Version 
Summary0000721: svnserve 1.14.0 (2020-09-05) crashes processing change-rev-prop
DescriptionI created a simple pre-revprop-change hook by editing the shebang line in the template to point to #!/@unixroot/bin/sh and saving without the file extension. Attempting a simple change to svn:log causes svnserve to trap.

Steps To Reproduce1. Create pre-revprop-change hook from template, pointing to valid Unix shell.
2. From the client, enter:

svn pe -r 15 --revprop svn:log <URL>

3. Edit the log entry as desired (in my test, I capitalized one letter).
4. Exit the editor, saving the file.
Additional InformationExpected result:

Log entry should be changed as edited.

Actual result:

svn: E210002: Network connection closed unexpectedly is returned to the client when svnserve crashes.

On the server side:

Killed by SIGSEGV
pid=0x0062 ppid=0x0061 tid=0x0002 slot=0x003a pri=0x0200 mc=0x0001 ps=0x0010
C:\VAR\TEMP\SUBVERSION\BIN\SVNSERVE.EXE
SVNSERVE 0:0007f45f
cs:eip=005b:0008f45f ss:esp=0053:0270fadc ebp=0270fb04
 ds=0053 es=0053 fs=150b gs=0000 efl=00010212
eax=37343a35 ebx=00000000 ecx=00000002 edx=21000000 edi=00000000 esi=0056d7c0
Process dumping was disabled, use DUMPPROC / PROCDUMP to enable it.

(Client is running svn.exe 20200905.)

.trp attached.
TagsNo tags attached.

Activities

LewisR

2020-09-06 15:30

developer  

0062_02.TRP (27,648 bytes)

psmedley

2020-09-09 19:32

administrator   ~0003539

can you try with http://smedley.id.au/tmp/subversion-1.14.0-os2-20200909.zip (not tested at all)

LewisR

2020-09-10 02:28

developer   ~0003540

Progress, of a sort.

No trap, but on the client side, I get:

svn: E165002: Failed to start 'V:/subversion/data114/svn14-snap-test/hooks/pre-revprop-change' hook
svn: E000003: Can't start process 'V:/subversion/data114/svn14-snap-test/hooks/pre-revprop-change':
No such process

(v:\subversion\data114 is the repo location on the server)

Nothing interesting in the server log:

13413 2020-09-09T16:52:19.171000Z 192.168.100.23 lgr svn14-snap-test open 2 cap=(edit-pipeline svndiff1 accepts-svndiff2 absent-entries depth mergeinfo log-revprops) / SVN/1.14.0%20(i386-pc-os2-emx) -
13413 2020-09-09T16:52:19.171000Z 192.168.100.23 lgr svn14-snap-test change-rev-prop r15 svn:log

Issue History

Date Modified Username Field Change
2020-09-06 15:30 LewisR New Issue
2020-09-06 15:30 LewisR File Added: 0062_02.TRP
2020-09-09 19:32 psmedley Note Added: 0003539
2020-09-10 02:28 LewisR Note Added: 0003540