View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|0000716||Subversion for OS/2 & eCS||Bug||public||2020-08-22 11:26||2023-09-24 17:48|
|Summary||0000716: svn.exe 1.14 echoes passwords in clear text when entered on command line|
|Description||This was an issue we saw with 1.7 at some point, though I don't see a ticket for it.|
|Steps To Reproduce||Enter password when prompted.|
|Tags||No tags attached.|
The code for this in 1.14 is completely different to 1.7.
Remind me - did we get this working correctly in heimdal's kinit?
Yes. Somewhere along the line, we got kinit to quiet down. Let me check my email...
From 2016/05/13, in the thread between you, Steve, and me, you said:
On 13/05/16 05:32, Steven Levine wrote:
> Anyway, I know how to fix this. Looking at ui.c, one would think it would
> use the HAVE_CONIO_H code path since we have a conio.h, but this is not
> the case. The other code path is used and it used getc which always
> Change the code to use the HAVE_CONIO_H code path and change the
> references to _getch and _getche to getch and getche and the password
> entry issue should be gone.
I also had to change _cprintf to printf
New hcrypto.dll at http://smedley.id.au/tmp/hcrypto-20160513.zip - seems to work ok here.
This was related to:
||ok that matches my vague recollections. Funnily enough, I could remember working on this code whilst staying in a holiday house down in Encounter bay - but I couldn't specifically recall that it fixed the password echoing. Let me have a play - there's code in subversion\libsvn_subr\prompt.c for win32 that uses conio that we may be able to adapt....|
||hmmmmm I tweaked terminal_getc() to use a variant of the win32 code and getch() (ala heimdal) but we're still getting password echoing... more thought required - current diff at http://smedley.id.au/tmp/subversion-1.14.0.diff|
||https://smedley.id.au/tmp/subversion-1.14.2-os2-20221015.zip might fix this.|
||@LewisR were you ever able to test the updated build?|
Reminder sent to: LewisR
|2020-08-22 11:26||LewisR||New Issue|
|2020-08-22 11:26||LewisR||Status||new => assigned|
|2020-08-22 11:26||LewisR||Assigned To||=> psmedley|
|2020-08-23 06:45||psmedley||Note Added: 0003492|
|2020-08-23 10:56||LewisR||Note Added: 0003494|
|2020-08-23 16:27||psmedley||Note Added: 0003501|
|2020-08-23 16:36||psmedley||Note Added: 0003502|
|2020-08-24 12:29||psmedley||Product Version||=> 1.14.x|
|2022-10-15 13:40||psmedley||Status||assigned => feedback|
|2022-10-15 13:40||psmedley||Note Added: 0004613|
|2023-09-24 17:47||psmedley||Note Added: 0004642|
|2023-09-24 17:48||psmedley||Note Added: 0004643|