View Issue Details

IDProjectCategoryView StatusLast Update
0000716Subversion for OS/2 & eCSBugpublic2020-08-24 12:29
ReporterLewisRAssigned Topsmedley 
PrioritynormalSeverityminorReproducibilityalways
Status assignedResolutionopen 
Product Version1.14.x 
Target VersionFixed in Version 
Summary0000716: svn.exe 1.14 echoes passwords in clear text when entered on command line
DescriptionThis was an issue we saw with 1.7 at some point, though I don't see a ticket for it.
Steps To ReproduceEnter password when prompted.
TagsNo tags attached.

Activities

psmedley

2020-08-23 06:45

administrator   ~0003492

The code for this in 1.14 is completely different to 1.7.

Remind me - did we get this working correctly in heimdal's kinit?

LewisR

2020-08-23 10:56

developer   ~0003494

Yes. Somewhere along the line, we got kinit to quiet down. Let me check my email...

From 2016/05/13, in the thread between you, Steve, and me, you said:

On 13/05/16 05:32, Steven Levine wrote:
> Anyway, I know how to fix this. Looking at ui.c, one would think it would
> use the HAVE_CONIO_H code path since we have a conio.h, but this is not
> the case. The other code path is used and it used getc which always
> echos.
>
> Change the code to use the HAVE_CONIO_H code path and change the
> references to _getch and _getche to getch and getche and the password
> entry issue should be gone.

I also had to change _cprintf to printf

New hcrypto.dll at http://smedley.id.au/tmp/hcrypto-20160513.zip - seems to work ok here.

This was related to:

https://trac.netlabs.org/kerberos/ticket/1

psmedley

2020-08-23 16:27

administrator   ~0003501

ok that matches my vague recollections. Funnily enough, I could remember working on this code whilst staying in a holiday house down in Encounter bay - but I couldn't specifically recall that it fixed the password echoing. Let me have a play - there's code in subversion\libsvn_subr\prompt.c for win32 that uses conio that we may be able to adapt....

psmedley

2020-08-23 16:36

administrator   ~0003502

hmmmmm I tweaked terminal_getc() to use a variant of the win32 code and getch() (ala heimdal) but we're still getting password echoing... more thought required - current diff at http://smedley.id.au/tmp/subversion-1.14.0.diff

Issue History

Date Modified Username Field Change
2020-08-22 11:26 LewisR New Issue
2020-08-22 11:26 LewisR Status new => assigned
2020-08-22 11:26 LewisR Assigned To => psmedley
2020-08-23 06:45 psmedley Note Added: 0003492
2020-08-23 10:56 LewisR Note Added: 0003494
2020-08-23 16:27 psmedley Note Added: 0003501
2020-08-23 16:36 psmedley Note Added: 0003502
2020-08-24 12:29 psmedley Product Version => 1.14.x