2017-12-17 20:16 ACDT

View Issue Details Jump to Notes ]
IDProjectCategoryView StatusLast Update
0000664Other Unix PortBugpublic2016-01-23 21:57
Reporterkomh 
Assigned To 
PrioritynormalSeverityminorReproducibilityalways
StatusnewResolutionopen 
Summary0000664: Cmake: Set suffix and prefix properly
DescriptionHi/2.

I think, it would be better not to use 'lib' prefix. On the other hand, it would better to use 'lib prefix when searaching libraries.

Review, please...
TagsNo tags attached.
Attached Files
  • patch file icon 0001-Add-lib-to-prefixes-for-library-search.patch (865 bytes) 2016-01-23 19:14 -
    From b3d612f6533a3fac091c5d53c52ae3a99e2f4309 Mon Sep 17 00:00:00 2001
    From: KO Myung-Hun <komh@chollian.net>
    Date: Thu, 21 Jan 2016 21:42:31 +0900
    Subject: [PATCH] Add 'lib' to prefixes for library search
    
        modified:   Modules/Platform/os2.cmake
    ---
     Modules/Platform/os2.cmake | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)
    
    diff --git a/Modules/Platform/os2.cmake b/Modules/Platform/os2.cmake
    index 9d7870a..f7db22a 100644
    --- a/Modules/Platform/os2.cmake
    +++ b/Modules/Platform/os2.cmake
    @@ -27,7 +27,7 @@ SET(CMAKE_MODULE_LINKER_FLAGS_INIT "-Zomf -Zdll")
     # Modules have a different default prefix that shared libs.
     SET(CMAKE_MODULE_EXISTS 1)
     
    -SET(CMAKE_FIND_LIBRARY_PREFIXES "" "")
    +SET(CMAKE_FIND_LIBRARY_PREFIXES "" "lib")
     SET(CMAKE_FIND_LIBRARY_SUFFIXES ".lib" ".a" ".dll" "_dll.a")
     
     SET(CMAKE_C_USE_RESPONSE_FILE_FOR_OBJECTS 1)
    -- 
    2.7.0
    
    
  • patch file icon 0001-Set-the-prefix-and-the-suffix-for-OS-2-static-librar.patch (861 bytes) 2016-01-23 19:14 -
    From da2c377cad77d059bd984e93162b44c6b99b42ed Mon Sep 17 00:00:00 2001
    From: KO Myung-Hun <komh@chollian.net>
    Date: Thu, 21 Jan 2016 21:41:32 +0900
    Subject: [PATCH] Set the prefix and the suffix for OS/2 static library
    
        modified:   Modules/Platform/os2.cmake
    ---
     Modules/Platform/os2.cmake | 2 ++
     1 file changed, 2 insertions(+)
    
    diff --git a/Modules/Platform/os2.cmake b/Modules/Platform/os2.cmake
    index bd1de6e..9d7870a 100644
    --- a/Modules/Platform/os2.cmake
    +++ b/Modules/Platform/os2.cmake
    @@ -8,6 +8,8 @@ SET(CMAKE_SHARED_MODULE_PREFIX "")
     SET(CMAKE_SHARED_MODULE_SUFFIX ".dll")
     SET(CMAKE_IMPORT_LIBRARY_PREFIX "")
     SET(CMAKE_IMPORT_LIBRARY_SUFFIX "_dll.a")
    +SET(CMAKE_STATIC_LIBRARY_PREFIX "")
    +SET(CMAKE_STATIC_LIBRARY_SUFFIX ".a")
     # no pic for gcc on OS/2
     SET(CMAKE_C_COMPILE_OPTIONS_PIC "")
     SET(CMAKE_CXX_COMPILE_OPTIONS_PIC "")
    -- 
    2.7.0
    
    

-Relationships
+Relationships

-Notes

~0003098

komh (reporter)

Ooooops. Sorry. This is for CMake.

I could not edit a summary.

~0003100

gianfli (reporter)

Last edited: 2016-01-23 21:57

View 3 revisions

Yes, I too believe this is the right way.
Well done ;) !

+Notes

-Issue History
Date Modified Username Field Change
2016-01-23 19:13 komh New Issue
2016-01-23 19:14 komh File Added: 0001-Add-lib-to-prefixes-for-library-search.patch
2016-01-23 19:14 komh File Added: 0001-Set-the-prefix-and-the-suffix-for-OS-2-static-librar.patch
2016-01-23 19:15 komh Note Added: 0003098
2016-01-23 19:19 psmedley Summary Set suffix and prefix properly => Cmake: Set suffix and prefix properly
2016-01-23 21:21 gianfli Note Added: 0003100
2016-01-23 21:33 gianfli Note Edited: 0003100 View Revisions
2016-01-23 21:57 gianfli Note Edited: 0003100 View Revisions
+Issue History